| Message ID | 1461242157-14223-2-git-send-email-msuraev@sysmocom.de |
|---|---|
| State | New |
| Series | "Series without cover letter" |
| Headers | show |
diff --git a/configure.ac b/configure.ac index 5274022..7a97954 100644 --- a/configure.ac +++ b/configure.ac @@ -3,7 +3,7 @@ AC_INIT([osmo-pcu], m4_esyscmd([./git-version-gen .tarball-version]), [osmocom-net-gprs@lists.osmocom.org]) -AM_INIT_AUTOMAKE([dist-bzip2]) +AM_INIT_AUTOMAKE([dist-bzip2 subdir-objects]) AC_CONFIG_TESTDIR(tests) dnl kernel style compile messages
Hi Max,
On Thu, Apr 21, 2016 at 02:35:54PM +0200, msuraev@sysmocom.de wrote:
> This helps to increase compatibility with newer automake.
I tried several times to add subdir-objects, but we always had to revert
these kind of changes, as they broke something. Don't recall what
exactly, but I think it was related to either out-of-source builds
and/or autotest? Holger?
It's currently enabled for libosmocore master. On 04/22/2016 02:38 PM, Harald Welte wrote: > Hi Max, > > On Thu, Apr 21, 2016 at 02:35:54PM +0200, msuraev@sysmocom.de wrote: >> This helps to increase compatibility with newer automake. > I tried several times to add subdir-objects, but we always had to revert > these kind of changes, as they broke something. Don't recall what > exactly, but I think it was related to either out-of-source builds > and/or autotest? Holger? >
See my mail from 17th Feb Cc'd to openbsc@, where I ask autoconf about the weird dirs showing up when subdir-objects is used, answered by Eric Blake of RedHat: [[[ > On Thu, Jan 14, 2016 at 02:40:38PM +0100, Neels Hofmeyr wrote: >> Dear autoconf, >> >> I am observing a bug with `autoreconf -i`. >> To my/our knowledge, this is not due to an error in >> our configuration but a genuine bug from 'subdir-objects'. >> >> The symptom: after running ./configure, I find a directory >> src/tests/\$(top_srcdir) This is a known automake bug, not caused by autoconf; that may explain why you haven't seen much response on the autoconf list, but I don't know if there are any active maintainers on the automake list that have suggestions on how to work around it, or on when a fixed automake will be available (or if it is already available). A quick search found this, though: https://lists.gnu.org/archive/html/automake/2015-12/msg00001.html ]]] Here is the openbsc@ thread: http://lists.osmocom.org/pipermail/openbsc/2016-February/007971.html So besides creating those weird directories, subdir-objects works AFAIK. We are currently using subdir-objects in osmo-iuh, libosmo-abis, libosmo-netif and last but not least libosmocore. (at least on 3G branches) ~Neels On Fri, Apr 22, 2016 at 02:38:21PM +0200, Harald Welte wrote: > Hi Max, > > On Thu, Apr 21, 2016 at 02:35:54PM +0200, msuraev@sysmocom.de wrote: > > This helps to increase compatibility with newer automake. > > I tried several times to add subdir-objects, but we always had to revert > these kind of changes, as they broke something. Don't recall what > exactly, but I think it was related to either out-of-source builds > and/or autotest? Holger? > > -- > - Harald Welte <laforge@gnumonks.org> http://laforge.gnumonks.org/ > ============================================================================ > "Privacy in residential applications is a desirable marketing option." > (ETSI EN 300 175-7 Ch. A6)
From: Max <msuraev@sysmocom.de> This helps to increase compatibility with newer automake. --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)