From patchwork Fri May 20 15:11:10 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: libosmocore[master]: gsm48: move to hex TMSI representation From: Vadim Yanitskiy X-Patchwork-Id: 70613 Message-Id: <20160520151112.7A01C6C1C@lists.osmocom.org> To: Harald Welte , Holger Freyther Date: Fri, 20 May 2016 15:11:10 +0000 Hello Harald Welte, Jenkins Builder, Holger Freyther, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/57 to look at the new patch set (#2). gsm48: move to hex TMSI representation Previously, we traditionally displayed a TMSI in its integer representation, which is quite unusual in the telecom world. A TMSI is normally printed as a series of 8 hex digits. Review at https://gerrit.osmocom.org/57/ Change-Id: Ifd25365bfa3b4ee95b16979740c3229948ce17f2 --- M src/gsm/gsm48.c 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/57/57/2 diff --git a/src/gsm/gsm48.c b/src/gsm/gsm48.c index 8a46f76..d0e050b 100644 --- a/src/gsm/gsm48.c +++ b/src/gsm/gsm48.c @@ -458,11 +458,10 @@ case GSM_MI_TYPE_NONE: break; case GSM_MI_TYPE_TMSI: - /* Table 10.5.4.3, reverse generate_mid_from_tmsi */ if (mi_len == GSM48_TMSI_LEN && mi[0] == (0xf0 | GSM_MI_TYPE_TMSI)) { memcpy(&tmsi, &mi[1], 4); tmsi = ntohl(tmsi); - return snprintf(string, str_len, "%u", tmsi); + return snprintf(string, str_len, "0x%08X", tmsi); } break; case GSM_MI_TYPE_IMSI: