openbsc[master]: Fix copy-paste error in SI6

Submitted by on May 23, 2016, 3:30 p.m.


Message ID
State New
Series "openbsc[master]: Fix copy-paste error in SI6"
Headers show

Commit Message May 23, 2016, 3:30 p.m.
Review at

Fix copy-paste error in SI6

Fix error which prevented enabling DTX for half-rate channels.

Change-Id: I7d41df0068783c8fb33ddeeab1d1dcf63c2c259f
M openbsc/src/libbsc/system_information.c
1 file changed, 1 insertion(+), 1 deletion(-)

  git pull ssh:// refs/changes/01/101/1

Patch hide | download patch | download mbox

diff --git a/openbsc/src/libbsc/system_information.c b/openbsc/src/libbsc/system_information.c
index 1f1d81e..bf20394 100644
--- a/openbsc/src/libbsc/system_information.c
+++ b/openbsc/src/libbsc/system_information.c
@@ -932,7 +932,7 @@ 
 	si6->cell_options = bts->si_common.cell_options;
 	si6->ncc_permitted = bts->si_common.ncc_permitted;
 	/* allow/disallow DTXu */
-	gsm48_set_dtx(&si6->cell_options, bts->dtxu, bts->dtxu, true);
+	gsm48_set_dtx(&si6->cell_options, bts->dtxu, bts->dtxu, false);
 	/* SI6 Rest Octets: PCH / NCH info, VBS/VGCS options */

Comments May 23, 2016, 4:24 p.m.
Patch Set 1: Code-Review+2

(1 comment)
File openbsc/src/libbsc/system_information.c:

Line 935: 	gsm48_set_dtx(&si6->cell_options, bts->dtxu, bts->dtxu, false);
Okay. so we are not on BCCH so it needs to be false here. But what do you think of using an enum value in the long run here?