From patchwork Mon May 23 20:20:37 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [MERGED] openbsc[master]: gsm04_08_clear_request(): release loc with arg release=0 From: Holger Freyther X-Patchwork-Id: 75283 Message-Id: <20160523202039.763A662B2@lists.osmocom.org> To: Neels Hofmeyr Date: Mon, 23 May 2016 20:20:37 +0000 Holger Freyther has submitted this change and it was merged. Change subject: gsm04_08_clear_request(): release loc with arg release=0 ...................................................................... gsm04_08_clear_request(): release loc with arg release=0 In gsm04_08_clear_request(), in_release == 1 anyway and msc_release_connection() would exit immediately without any effect. Don't confuse the reader by passing release=1 arg. Change-Id: I5bf9eb4889d32ad5e42ac7d096bf62fa3a493e20 Reviewed-on: https://gerrit.osmocom.org/93 Reviewed-by: Holger Freyther Tested-by: Jenkins Builder --- M openbsc/src/libmsc/gsm_04_08.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified Holger Freyther: Looks good to me, approved diff --git a/openbsc/src/libmsc/gsm_04_08.c b/openbsc/src/libmsc/gsm_04_08.c index 68cc906..74da34b 100644 --- a/openbsc/src/libmsc/gsm_04_08.c +++ b/openbsc/src/libmsc/gsm_04_08.c @@ -384,7 +384,7 @@ * Cancel any outstanding location updating request * operation taking place on the subscriber connection. */ - release_loc_updating_req(conn, 1); + release_loc_updating_req(conn, 0); /* We might need to cancel the paging response or such. */ if (conn->sec_operation && conn->sec_operation->cb) {