ggsn/cmdline: remove unused variable check_required

Submitted by Alexander Couzens on May 31, 2016, 12:47 p.m.

Details

Message ID 20160531124754.3107-1-lynxis@fe80.eu
State New
Series "ggsn/cmdline: remove unused variable check_required"
Headers show

Commit Message

Alexander Couzens May 31, 2016, 12:47 p.m.
fix an unused warning
---
 ggsn/cmdline.c | 2 --
 1 file changed, 2 deletions(-)

Patch hide | download patch | download mbox

diff --git a/ggsn/cmdline.c b/ggsn/cmdline.c
index 31c0744..2ef87cb 100644
--- a/ggsn/cmdline.c
+++ b/ggsn/cmdline.c
@@ -609,14 +609,12 @@  cmdline_parser_internal (
   
   int override;
   int initialize;
-  int check_required;
   int check_ambiguity;
   
   package_name = argv[0];
   
   override = params->override;
   initialize = params->initialize;
-  check_required = params->check_required;
   check_ambiguity = params->check_ambiguity;
 
   if (initialize)

Comments

msuraev@sysmocom.de May 31, 2016, 1:15 p.m.
I think we should drop ggsn/cmdline.* from git and add compile-time
dependency on gengetopt. It's available everywhere anyway and this would
match the way we deal with generated code in libosmocore.

On 05/31/2016 02:47 PM, Alexander Couzens wrote:
> fix an unused warning
> ---
>  ggsn/cmdline.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/ggsn/cmdline.c b/ggsn/cmdline.c
> index 31c0744..2ef87cb 100644
> --- a/ggsn/cmdline.c
> +++ b/ggsn/cmdline.c
> @@ -609,14 +609,12 @@ cmdline_parser_internal (
>    
>    int override;
>    int initialize;
> -  int check_required;
>    int check_ambiguity;
>    
>    package_name = argv[0];
>    
>    override = params->override;
>    initialize = params->initialize;
> -  check_required = params->check_required;
>    check_ambiguity = params->check_ambiguity;
>  
>    if (initialize)
Harald Welte June 2, 2016, 12:19 p.m.
On Tue, May 31, 2016 at 03:15:30PM +0200, Max wrote:
> I think we should drop ggsn/cmdline.* from git and add compile-time
> dependency on gengetopt. It's available everywhere anyway and this would
> match the way we deal with generated code in libosmocore.

fine with me.  Will somebody work on a patch?